Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F vpclattice resource policy data source #31372

Merged

Conversation

sQu4rks
Copy link
Contributor

@sQu4rks sQu4rks commented May 12, 2023

Description

Adds support for the resource policy data source

Relations

Relates #30380

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccDataSourceResourcePolicy_ PKG=vpclattice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20 -run='TestAccDataSourceResourcePolicy_'  -timeout 180m
=== RUN   TestAccDataSourceResourcePolicy_basic
=== PAUSE TestAccDataSourceResourcePolicy_basic
=== CONT  TestAccDataSourceResourcePolicy_basic
--- PASS: TestAccDataSourceResourcePolicy_basic (24.41s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice 27.726s
...

Marcel Neidinger added 6 commits May 5, 2023 10:22
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. partner Contribution from a partner. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/vpclattice Issues and PRs that pertain to the vpclattice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels May 12, 2023
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 12, 2023
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label May 12, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCLatticeResourcePolicyDataSource_' PKG=vpclattice
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/vpclattice/... -v -count 1 -parallel 20  -run=TestAccVPCLatticeResourcePolicyDataSource_ -timeout 180m
=== RUN   TestAccVPCLatticeResourcePolicyDataSource_basic
=== PAUSE TestAccVPCLatticeResourcePolicyDataSource_basic
=== CONT  TestAccVPCLatticeResourcePolicyDataSource_basic
--- PASS: TestAccVPCLatticeResourcePolicyDataSource_basic (19.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/vpclattice	24.580s

@ewbankkit
Copy link
Contributor

@sQu4rks Thanks for the contribution 🎉 👏.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. partner Contribution from a partner. service/vpclattice Issues and PRs that pertain to the vpclattice service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants